search

wearerequired / WP-Widget-Disable

🖼 A WordPress plugin that allows you to disable Sidebar and Dashboard Widgets.
https://wordpress.org/plugins/wp-widget-disable/
GNU General Public License v2.0
16 stars 6 forks source link

Duplicate notices #7

Closed swissspidy closed 8 years ago

swissspidy commented 9 years ago

The success message is always displayed twice.

swissspidy commented 8 years ago

Can't reproduce.

swissspidy commented 8 years ago

Apparently still an issue

screen shot 2016-07-10 at 16 41 40
swissspidy commented 8 years ago

Funnily this only happens when 1 widget is disabled, not when checking multiple boxes.

neverything commented 8 years ago

Maybe it's because of the settings_errors() call? https://github.com/wearerequired/WP-Widget-Disable/blob/ae63e7881d71a0eaf7b337bf15ca26a2a0d8c770/views/admin.php#L18

See "duplicate admin notices": https://digwp.com/2016/05/wordpress-admin-notices/

swissspidy commented 8 years ago

D'oh, that indeed sounds like a duplicated call to display settings errors.

swissspidy commented 8 years ago

Now I can't reproduce it again. So fun.