wearerequired / lint-action

✨ GitHub Action for detecting and auto-fixing lint errors
MIT License
554 stars 130 forks source link

Checks annotation limit #749

Open cbackas opened 6 months ago

cbackas commented 6 months ago

Hey I use this for some personal projects and thought I'd bring it into work to increase the visibility of issues so we can start getting them all fixed. Well turns out our projects have many more than 50 annotations and I'd like to have them all in github but this action simply drops everything after 50.

I went ahead and forked the repo and threw together the changes to chunk the annotations and send them all with rate limit handling but the contrib guidelines said to make an issue before PRs so here I am.

@ocean90 since you seem to be the main person around here, does this sound like something we could get merged in?

Update: went to test my first pass of the code and it didn't work but I got it fixed up and uploaded 2607 annotations no problemo

image
cbackas commented 6 months ago

@ocean90 any any feedback on this concept? Would love to know if I should commit to our organization using a fork or not.

As a side note, I'd be happy to change the HTTP requests to use the octokit/rest.js library since its what github recommends in their docs. This would remove the need to handle rate limiting in the 'request' function (and can maybe delete the function entirely) and also remove the manual handling of headers. Another dependency is something to consider tho, so just let me know.

github-actions[bot] commented 6 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 5 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

cbackas commented 5 months ago

https://github.com/wearerequired/lint-action/pull/764