build!: update action and dependencies to node 20

[hugo-vrijswijk]

Node 16 actions will be deprecated soon and are already giving warnings in CI when this action is used.

[hugo-vrijswijk]

A lot of tests are failing due to incorrect lint result comparisons. Probably due to a different build since the last time this repo was touched. I've updated a few of them, but I think fixing the CI is outside of scope for this PR. Other PR's also seem to be failing. I'm not familiar enough with the code or most of the tools to want to touch them any more.

Edits are allowed by maintainers, so any fixes to the build can be picked up by someone else (@ocean90 ?) .

[INRIX-Iurii-Okhmat]

@ocean90, @hugo-vrijswijk Hello, I wonder what needs to happen to get this moving? We rely heavily on this action across numerous projects and it's pretty much the only one left not updated to node20

[ocean90]

I wonder what needs to happen to get this moving?

We'd need someone who can make the tests passing again. Either in this PR or in a separate one.

[hugo-vrijswijk]

My suggestion would be to merge this PR and fix the tests in a separate one. I'm not familiar enough with this repo to do it, but I don't know who would be

[erikburt]

This action is likely to break on May 13 - see https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/.

Node16 has been out of support since September 2023. As a result we have started the deprecation process of Node16 for GitHub Actions. We plan to migrate all actions to run on Node20 by Spring 2024. Following on from our warning in workflows using Node16 we will start enforcing the use of Node20 rather than Node16 on the 13th of May.

---

@ocean90 can you prioritize merging this, and the tests can be fixed retroactively.

[ocean90]

@ocean90 can you prioritize merging this, and the tests can be fixed retroactively.

That's not possible. The tests need to be fixed first so we can ensure that changes in this PR don't introduce any issues.

[hugo-vrijswijk]

@ocean90 can you prioritize merging this, and the tests can be fixed retroactively.

That's not possible. The tests need to be fixed first so we can ensure that changes in this PR don't introduce any issues.

The failing build is due to an outdated build environment setup. Any CI job on master will also fail currently. That makes developing very difficult, as I don't know what/if I've broken with my changes. If the master branch is stable, I'd be more than happy to update this PR and get everything green.

Many people are dependent on this action, which as mentioned above will likely break in less than two weeks (May 13). It would be very helpful if this got merged soon, so someone who knows the code can fix the tests. Merging this now (and publishing a release) would at the very least give people a working version after May 13.

It seems this repo is not very actively maintained any more. If there is no one to actively maintain it, it's understandable, but I think a lot of people would appreciate it if the repo could be archived with a clear notice, or transferred to someone who can maintain it.

[erikburt]

Although Github extended the deprecation of node16 by a few months, I have removed any of my dependencies on this action.

I unfortunately suggest you do the same.

[dystopiandev]

What did you switch to? @erikburt

[hugo-vrijswijk]

I was only using stylelint and prettier, so switching was just a two-line script:

      - name: Run linters
        run: |
          npx prettier --check .
          npx stylelint --formatter github .

[hugo-vrijswijk]

I'm closing this PR. It's a shame this repo seems like it's dead, and not a very good sign for an organization that wants to have a good open source image