search

wearerequired / traduttore

🗼 A WordPress plugin to improve the I18N workflow for your own projects based on @GlotPress.
https://wearerequired.github.io/traduttore/
72 stars 15 forks source link

Improve repository name extraction from source url template #101

Closed swissspidy closed 5 years ago

swissspidy commented 5 years ago

Description Fixes an issue where the parts after the repository name weren't removed.

Without this change, the repository name (wearerequired/traduttore) isn't being correctly derived from the source url template (https://github.com/wearerequired/traduttore/tree/master/%file%#L%line%).

How has this been tested? Updated unit tests accordingly.

Types of changes Nice little bug fix!

Checklist:

codecov-io commented 5 years ago

Codecov Report

Merging #101 into master will decrease coverage by 0.2%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #101      +/-   ##
============================================
- Coverage     74.16%   73.95%   -0.21%     
+ Complexity      322      319       -3     
============================================
  Files            23       23              
  Lines           774      768       -6     
============================================
- Hits            574      568       -6     
  Misses          200      200
Impacted Files Coverage Δ Complexity Δ
inc/Repository/GitLab.php 96% <100%> (-0.3%) 11 <0> (-1)
inc/Repository/Bitbucket.php 97.61% <100%> (-0.11%) 24 <0> (-1)
inc/Repository/GitHub.php 100% <100%> (ø) 10 <0> (-1) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1013216...07125e2. Read the comment docs.

swissspidy commented 5 years ago

They shouldn't have been passing before actually 🙈