search

wearerequired / traduttore

🗼 A WordPress plugin to improve the I18N workflow for your own projects based on @GlotPress.
https://wearerequired.github.io/traduttore/
72 stars 12 forks source link

Include translations for JavaScript files in language packs #108

Closed ocean90 closed 5 years ago

ocean90 commented 5 years ago

This is supposed to fix #62.

As a first step parts of https://meta.trac.wordpress.org/changeset/7833/ are added to the ZipProvider class.

codecov-io commented 5 years ago

Codecov Report

Merging #108 into master will increase coverage by 1.38%. The diff coverage is 98.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #108      +/-   ##
============================================
+ Coverage     78.05%   79.43%   +1.38%     
- Complexity      333      354      +21     
============================================
  Files            23       24       +1     
  Lines           802      856      +54     
============================================
+ Hits            626      680      +54     
  Misses          176      176
Impacted Files Coverage Δ Complexity Δ
inc/ZipProvider.php 100% <100%> (+1.11%) 23 <0> (-4) :arrow_down:
inc/Export.php 98.61% <98.61%> (ø) 25 <25> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a580c45...0059a6f. Read the comment docs.

swissspidy commented 5 years ago

@ocean90 What do you think of the current approach so far?

swissspidy commented 5 years ago

@ocean90 Somehow I can't select you as a reviewer 🤔 Let me know what you think of the current PR.