wearerequired / traduttore

🗼 A WordPress plugin to improve the I18N workflow for your own projects based on @GlotPress.

https://wearerequired.github.io/traduttore/

72 stars 15 forks source link

Fix issue with empty language pack ZIP #169

Closed florianbrinkmann closed 4 years ago

florianbrinkmann commented 4 years ago

Description

I changed the second parameter of ZipArchive->open() to OVERWRITE in order to fix #168.

How has this been tested? With the wp traduttore language-pack build command. It generates an empty ZIP with CREATE and a correct ZIP with OVERWRITE.

Types of changes Bug fix

Checklist:

[ ] My code is tested.
[x] My code follows the WordPress code style.
[x] My code has proper inline documentation.

swissspidy commented 4 years ago

Codecov Report

Merging #169 into master will not change coverage by %. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #169   +/-   ##
=========================================
  Coverage     79.63%   79.63%           
  Complexity      397      397           
=========================================
  Files            24       24           
  Lines           928      928           
=========================================
  Hits            739      739           
  Misses          189      189

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 706ea69...b87901d. Read the comment docs.

codecov-io commented 4 years ago

Codecov Report

Merging #169 into master will not change coverage by %. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #169   +/-   ##
=========================================
  Coverage     79.63%   79.63%           
  Complexity      397      397           
=========================================
  Files            24       24           
  Lines           928      928           
=========================================
  Hits            739      739           
  Misses          189      189

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 706ea69...6a7ebea. Read the comment docs.

ocean90 commented 4 years ago

Thank you!

florianbrinkmann commented 4 years ago

You’re welcome, thanks for the fast feedback and merge!