Closed florianbrinkmann closed 4 years ago
Merging #169 into master will not change coverage by
%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #169 +/- ##
=========================================
Coverage 79.63% 79.63%
Complexity 397 397
=========================================
Files 24 24
Lines 928 928
=========================================
Hits 739 739
Misses 189 189
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 706ea69...b87901d. Read the comment docs.
Merging #169 into master will not change coverage by
%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #169 +/- ##
=========================================
Coverage 79.63% 79.63%
Complexity 397 397
=========================================
Files 24 24
Lines 928 928
=========================================
Hits 739 739
Misses 189 189
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 706ea69...6a7ebea. Read the comment docs.
Thank you!
You’re welcome, thanks for the fast feedback and merge!
Description
I changed the second parameter of
ZipArchive->open()
toOVERWRITE
in order to fix #168.How has this been tested? With the
wp traduttore language-pack build
command. It generates an empty ZIP withCREATE
and a correct ZIP withOVERWRITE
.Types of changes Bug fix
Checklist: