search

wearerequired / traduttore

🗼 A WordPress plugin to improve the I18N workflow for your own projects based on @GlotPress.
https://wearerequired.github.io/traduttore/
72 stars 15 forks source link

Translation version when updating translation in glotpress #214

Closed kimmenbert closed 2 years ago

kimmenbert commented 3 years ago

Issue Overview We're using Traduttore only to get the API endpoint needed to install translations from custom glotpress installation trough composer using inpsyde/wp-translation-downloader

Finally got this working ok, translation got installed from our custom glotpress. But when we're making updates to the translations in glotpress, no version update gets triggered. Based on your code I see that this probably only happens when integrated to github / bitbucket etc.

Do you have any idea how we could bump versions when doing edits in glotpress?

To Reproduce Steps to reproduce the behavior:

  1. Make a project with a translation
  2. Do a GET request to /api/translations/PROJECTSLUG
  3. See version 1.0
  4. Make changes to the translation in glotpress
  5. Repeat from step 2.

Expected behavior I don't really expect this to work, since it doesn't seem like the main goal of traduttore.

Versions Traduttore: 3.1.0 GlotPress: 2.3.1 WordPress: 5.7.1

ocean90 commented 3 years ago

Hello there, the version you're seeing there is the version of the plugin/theme. Translations don't have a specific version. So unless you update the version of the plugin/theme the version field doesn't change on translation changes. The only thing that changes is the updated field which is used to compare your local translation files to check for updates.