GitLab: Repository visibility is inverted - Githubissues

wearerequired / traduttore

🗼 A WordPress plugin to improve the I18N workflow for your own projects based on @GlotPress.

https://wearerequired.github.io/traduttore/

72 stars 12 forks source link

GitLab: Repository visibility is inverted #217

Closed ocean90 closed 3 years ago

ocean90 commented 3 years ago

Issue Overview There are two issues:

The webhook is using an incorrect value for checking if a project is public or not. Currently any private project will be set to public and and vice versa.
The API request in the GitLab repository class is not URL encoding the project thus all projects will be set to private

To Reproduce Steps to reproduce the behavior:

Create a private GitLab project
Trigger the first webhook
Run wp traduttore project info <project> and notice that "Repository Visibility" prints "public.

Expected behavior GitLab projects get the the correct visibility assigned