Open ocean90 opened 3 years ago
It's also impossible to tell whether the update failed at the POT generation or at the import stage in Updater::update()
.
Throwing exceptions throughout the codebase for failures like this, which could then be caught in ProjectCommand
or earlier, would make this easier for sure.
Issue Overview
It would be nice to display why exactly the translations could not be updated. The command uses
Runner:run()
which unfortunately only returns "True on success, false otherwise.". In my case it was a stale lock so I was expecting that the warning would mention that.I think
Runner:run()
should be updated to return aWP_Error
object or throw an exception in case of failures.