search

wearerequired / traduttore

🗼 A WordPress plugin to improve the I18N workflow for your own projects based on @GlotPress.
https://wearerequired.github.io/traduttore/
72 stars 12 forks source link

Update wearerequired/coding-standards to 2.0 #219

Closed grappler closed 2 years ago

grappler commented 3 years ago

Description Update wearerequired/coding-standards to version 2.0.

After changing the array type hint PHPStan was returning the following error:

 ------ --------------------------------------------- 
  Line   CLI/LanguagePackCommand.php                  
 ------ --------------------------------------------- 
  173    Negated boolean expression is always false.  
 ------ ---------------------------------------------

To fix this I moved the check if the project really existed to check_optional_args_and_all().

How has this been tested? I tested it by running wp traduttore language-pack build 9999999 as the project 9999999 does not exist.

Types of changes Improve coding standards and return notice if project does not exist.

Checklist:

ocean90 commented 3 years ago

These changes were already done in https://github.com/wearerequired/traduttore/pull/124 so not sure if we want to break that PR again.

Also as mentioned in https://github.com/wearerequired/traduttore/pull/201#issuecomment-847744344, we'd have to update the PHP requirement too.

grappler commented 3 years ago

Happy to leave it on hold if #124 gets merged soon.

As wearerequired/coding-standards is only a dev dependency. It might still work to not have to increase the PHP version of the released code. I will try to test this.

ocean90 commented 3 years ago

As wearerequired/coding-standards is only a dev dependency. It might still work to not have to increase the PHP version of the released code. I will try to test this.

The issue is that it also suggests PHP 7.4 features which may cause problems. But there's nothing wrong with just adding the type hints but keeping the old version for now, like done in #124.

codecov[bot] commented 2 years ago

Codecov Report

Merging #219 (07a42e2) into master (5b84001) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #219   +/-   ##
=========================================
  Coverage     81.21%   81.21%           
  Complexity      369      369           
=========================================
  Files            24       24           
  Lines           942      942           
=========================================
  Hits            765      765           
  Misses          177      177
Flag Coverage Δ
feature ?
php 81.21% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
inc/Configuration.php 100.00% <ø> (ø)
inc/Export.php 98.75% <ø> (ø)
inc/Project.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5b84001...07a42e2. Read the comment docs.