wearerequired / traduttore

🗼 A WordPress plugin to improve the I18N workflow for your own projects based on @GlotPress.
https://wearerequired.github.io/traduttore/
72 stars 12 forks source link

Update workflows #236

Closed ocean90 closed 2 years ago

ocean90 commented 2 years ago

Description

How has this been tested?

Screenshots If applicable, add screenshots to show the visual change.

Types of changes Breaking change

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #236 (a099b39) into master (65e08d6) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #236   +/-   ##
=========================================
  Coverage     81.21%   81.21%           
  Complexity      369      369           
=========================================
  Files            24       24           
  Lines           942      942           
=========================================
  Hits            765      765           
  Misses          177      177           
Flag Coverage Δ
feature ?
php 81.21% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
inc/Plugin.php 44.64% <ø> (ø)
inc/WebhookHandlerFactory.php 100.00% <ø> (ø)
inc/ZipProvider.php 98.79% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 65e08d6...a099b39. Read the comment docs.

ocean90 commented 2 years ago

@swissspidy Do you maybe have an idea why the @require-php-7.4 tag for the behat tests isn't working?

swissspidy commented 2 years ago

@ocean90 Looks like wp-cli-tests' behat-tags.php looks for tests in the features/ folder by default, which breaks the tags.

This can be addressed by setting the `` environment variable though:

https://github.com/wp-cli/wp-cli-tests/blob/e387388712add62664278aeb89517734fe5e13fd/utils/behat-tags.php#L43

So this works:

BEHAT_FEATURES_FOLDER=tests/features composer behat
ocean90 commented 2 years ago

So this works:

BEHAT_FEATURES_FOLDER=tests/features composer behat

@swissspidy Thanks for the hint. Looks like that and https://github.com/wearerequired/traduttore/pull/236/commits/30b68ece7a19a5b28440ae921693b13dcf613cf8 did fix it.

swissspidy commented 2 years ago

So this works:

BEHAT_FEATURES_FOLDER=tests/features composer behat

@swissspidy Thanks for the hint. Looks like that and 30b68ec did fix it.

IIRC I used vendor/bin/behat there because there were otherwise issues with code coverage gathering. But since that is currently not working anyway, should be fine for now.

Though it would be nice to fix the code coverage eventually :)