Avoid Slack notifications for imports without changes

wearerequired / traduttore

🗼 A WordPress plugin to improve the I18N workflow for your own projects based on @GlotPress.

https://wearerequired.github.io/traduttore/

72 stars 12 forks source link

Avoid Slack notifications for imports without changes #35

Closed ocean90 closed 6 years ago

ocean90 commented 6 years ago

When nothing has changes you get the following notification:

Project Name: 0 new strings were added, 0 were fuzzied, and 0 were obsoleted. There were 0 errors

IMO we should suppress such messages in https://github.com/wearerequired/traduttore/blob/0e9e7f63d4a13a6e626be4f9ee2da525e8325a59/inc/Plugin.php#L112-L130.

swissspidy commented 6 years ago

Looks like returning false in that callback avoids sending anything.

I guess it makes sense. When you push lots of commits without any changes, it can become quite noisy. On the other hand, it lets you know that the service is still working properly.

grappler commented 6 years ago

This does not seem to be fixed.

ocean90 commented 6 years ago

@grappler Are you sure that you are using 2.0.3 which was just released seconds ago?