wearerequired / traduttore

🗼 A WordPress plugin to improve the I18N workflow for your own projects based on @GlotPress.
https://wearerequired.github.io/traduttore/
72 stars 12 forks source link

Check if build time is set #56

Closed grappler closed 6 years ago

grappler commented 6 years ago

I came across the problem where the translations were not updating as the "updated" value was false which caused WP-CLI to save the translations zip without an updated time. This meant there was always an update for the plugin but it was not really updated.

This problem arose as the zip files were created before the new feature for the updated time was added. I think it is better to be cautious and not show the zip information if crucial data is missing.

swissspidy commented 6 years ago

This shouldn‘t happen nowadays, right? Should we perhaps queue another build if the meta data is missing?

grappler commented 6 years ago

This shouldn't happen nowadays, right?

Yes, but I am not sure if there will be cases where the value is not valid when set https://github.com/wearerequired/traduttore/blob/6655e70fbd0abf52bc93d9542a5520d379df83fe/inc/ZipProvider.php#L131

Should we perhaps queue another build if the meta data is missing?

That would be a good idea. Here is another example: https://translate.required.com/api/translations/foodward/foodward-post-types/

codecov-io commented 6 years ago

Codecov Report

Merging #56 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #56   +/-   ##
=========================================
  Coverage     67.93%   67.93%           
- Complexity      188      189    +1     
=========================================
  Files            17       17           
  Lines           499      499           
=========================================
  Hits            339      339           
  Misses          160      160
Impacted Files Coverage Δ Complexity Δ
inc/TranslationApiRoute.php 100% <100%> (ø) 5 <0> (+1) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 76dcf5c...964fc27. Read the comment docs.