search

wearerequired / traduttore

🗼 A WordPress plugin to improve the I18N workflow for your own projects based on @GlotPress.
https://wearerequired.github.io/traduttore/
72 stars 12 forks source link

Use separate settings field for repository URL #57

Open swissspidy opened 6 years ago

swissspidy commented 6 years ago

This way we don't have to guess the repsitory URL based on the "Source file URL" field.

Also, one might want to use Traduttore without having "Source file URL" set.

swissspidy commented 6 years ago

Looking at GlotPress code, this won‘t be feasible without overriding the complete template file I think.

Here‘s another thought I had:

When we receive an incoming webhook for a given project, we store the repository type (gitlab, github, etc.) and perhaps the URL/host as project meta. In theory also the vcs type (git/hg) for Bitbucket repositories.

This way when trying to clone the repository we don‘t have to figure out where it resides, which is of course useful for self-hosted GitLab and things like that.

swissspidy commented 6 years ago

Ideally we‘d also have settings fields for the webhook secrets.

swissspidy commented 6 years ago

When we receive an incoming webhook for a given project, we store the repository type (gitlab, github, etc.) and perhaps the URL/host as project meta. In theory also the vcs type (git/hg) for Bitbucket repositories.

That already works now.

Ideally we‘d also have settings fields for the webhook secrets.

-> #80

swissspidy commented 6 years ago

Looking at GlotPress code, this won‘t be feasible without overriding the complete template file I think.

@ocean90 Can you confirm this?

ocean90 commented 6 years ago

You mean project-form.php? Yes, there's no filter yet. Maybe worth creating an issue/PR?

swissspidy commented 6 years ago

Opened an issue upstream: https://github.com/GlotPress/GlotPress-WP/issues/969