wearerequired / traduttore

🗼 A WordPress plugin to improve the I18N workflow for your own projects based on @GlotPress.
https://wearerequired.github.io/traduttore/
72 stars 12 forks source link

Add --cached flag to update command #94

Closed swissspidy closed 5 years ago

swissspidy commented 6 years ago

Description As the title says, this change adds support for a --cached flag to the update command.

Fixes #79.

How has this been tested? Manual testing + unit test coverage.

Types of changes Extends UpdateCommand and Runner::run() to skip downloading the remote repository and instead use the local one.

Checklist:

codecov-io commented 6 years ago

Codecov Report

Merging #94 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##             master   #94   +/-   ##
======================================
  Coverage        75%   75%           
- Complexity      334   336    +2     
======================================
  Files            23    23           
  Lines           804   804           
======================================
  Hits            603   603           
  Misses          201   201
Impacted Files Coverage Δ Complexity Δ
inc/Runner.php 100% <100%> (ø) 9 <5> (+2) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7576f25...9808815. Read the comment docs.

swissspidy commented 6 years ago

Right, I thought it did return null. Well then of course we have to check whether the directory exists.

swissspidy commented 5 years ago

Looks like the docblock was removed when I resolved the most recent merge conflicts. Added back now.