Open psousa opened 9 years ago
Yes, didn't have time for those. Probably by the end of the week.
Ok. No problem. Good job. You can merge whenever you want.
Hi! Any chance of completing this merge anytime soon?
Any chance of completing this merge anytime soon?
@donbonifacio would be great to merge this. this is actually missing in the implementation.
@psousa can you take a look into this conflicts?
@igorescobar I cloned this repo onto my own account and implemented the invoice receipts part (which is the part I was missing for my project). I did not include any tests. Seems to be working fine so far. Feel free to use from: https://github.com/vascosantos/invoicexpress-gem
@vascosantos cool but @paulosilva86 gave the green light to merge this and somehow It wasn't...
@igorescobar, I saw that as well, but the merge has been pending for more than 1 year. So I looked at the diffs in the code and copy&pasted on the repository I sent you.
👓
I didn't receive notifications from these comments.
So 3 things:
I hope further pull requests will be done in a faster, more orderly way.
I'll paste below the changes I've made:
Added current_invoice_receipt_number and current_invoice_receipt_sequence_id to sequences.
Merged changes from other contributors. Bumped version.
More big changes on this version:
Big changes on this version:
Support for 429 RateLimitExceeded code Added Invoice Receipt Added supplier model
:ok: Still missing tests for InvoiceReceipts though right?