Closed robertocarroll closed 8 years ago
@pauldwaite we need to include the status definition in the detailbox below the status.
dictionary.getTranslation('COUNTRIES')
?A couple of related questions:
Ah yes — I think I must have made a mistake when doing the localisation that lost the status description from the detail box. I’ve put it back in now, although it’s in an <h3>
tag, and the styling is different (bolder) to that screenshot.
What do you think about using a table to achieve two fixed height fluid columns side by side?
Sounds good.
is the height of the detailbox fixed?
Right now it’s as tall as #info-box-inner
(minus space at the top to allow the year to still be visible), which is only as tall as its contents.
I guess we never really know how much vertical space we have for this component, as it could be included anywhere. And I guess we don’t want the whole thing to be scrollable? So I think maybe the detail box itself will need to have its content be scrollable?
I think I fixed the side by side but opening a couple of new issues for the detailbox height and the sizing of the icon / figures.
Agreed to take another look at this as in the original designs.