wearethoughtfox / amnesty-facebook

0 stars 0 forks source link

Put dictionary in json file and load #29

Closed robertocarroll closed 7 years ago

robertocarroll commented 7 years ago

Makes it cleaner for content editors

robertocarroll commented 7 years ago

Do you think this is necessary? I had a quick go and got stuck with the async loading of the json.

robertocarroll commented 7 years ago

The problem was:

And sometimes Facebook was loading before the dictionary ... (that's when I gave up).

Also (and slightly unrelated), but I'm making a note that perhaps we need to wait until everything's loaded for the .start to fire:

$(document).ready(function(){
   amnestyApp.start();
});
robertocarroll commented 7 years ago

I made a branch with the start of the external dictionary: https://github.com/wearethoughtfox/amnesty-facebook/tree/dictionary-external

But still stuck on the problem outlined above.

robertocarroll commented 7 years ago

Thank you. Never would have got to this on my own!