search

wearethoughtfox / amnesty-facebook

0 stars 0 forks source link

After posting a message on Facebook, we show the Amnesty website in an iframe. Is that right? #36

Closed pauldwaite closed 7 years ago

pauldwaite commented 7 years ago

If so, cool, but it does look a bit odd if the user hasn’t already visited the Amnesty site (unlikely, I guess), as then they get Amnesty’s cookie warning taking up half of the iframe.

iframe-um

robertocarroll commented 7 years ago

This is meant to show some kind of call to action (which we don't have yet) in an iFrame, so this bit was just demonstrating showing the content in an iFrame. The content on the iFrame will actually vary according to the user's region (one of five, I think) which we need to work out from their location provided by Facebook. Hurray!

pauldwaite commented 7 years ago

Gotcha. Will we have a default call-to-action to show, in case any real users don’t have a location (like our test users don’t)?

robertocarroll commented 7 years ago

Yes, good idea.

robertocarroll commented 7 years ago

Closing. See #53