weareunderdesign / rnbw

design. develop. ship.
https://rnbw.dev
GNU General Public License v3.0
57 stars 13 forks source link

UI enhancements #150

Closed edenvidal closed 1 year ago

edenvidal commented 1 year ago
sbsoso0411 commented 1 year ago

1.

why are there files with an icon without a name? how do we avoid it?

we needed to hide file extensions in tree view, you remember? so if the file names are like .***, there will be no name in tree view. but if the file extensions are known, such as .js or .html it will have an icon but no name. what should we do? :)

2. what you mean with the sidebar is ActionsPanel(FileTreeView+NodeTreeView+SettingsView), correct? and should we add \ cmdk to reference csv, or just in code? I am asking since if we add it to ref.csv, it will appear in Cmdk Modal UI, you see?

3.

resizable panels glitch on the big screen? visual glitch - there's some kinds of offset spacing underneath the interface which is scrollable when getting to the bottom.

excuse me, I am not sure how I can reproduce them. could you give me more info please?

@edenvidal

edenvidal commented 1 year ago
  1. i'm trying to figure out your ruling around this but i am a bit confused. how could it be that there is a file without a name? also there's the case when there's no icon and no file - what does it mean? let's get to the bottom of it since its confusing Screenshot 2023-04-13 at 14 03 18
  2. the \ command is already in references and appears in the menu. but it doesn't work.
  3. ignore this comment about the code view. here's a video about the offset problem - https://www.loom.com/share/26e249fe6d0b43c2a899d535a910f2d7

@sbsoso0411

sbsoso0411 commented 1 year ago

@edenvidal 1. so the only way I am thinking is to show file names and extensions together in tree view. what do you think? VisualCode also does that way. :)

edenvidal commented 1 year ago

yes let's do it this way for now @sbsoso0411 (:

sbsoso0411 commented 1 year ago

@edenvidal I see the reason why we are saying "for now".. ☝ showing names and extensions together seems a bit ... not good for rnbw app, right? because if we want to add a file, we will choose the file type in cmdk modal. so maybe we should enter only file names in the input box.

and also I've had a check through the code and if we decide to show file names and extensions together, we will need to improve some code. it's not too easy. :) since it will change the file-rename mode.(you will enter file extensions when renaming too.)

so here's my thought. I think we can hide the files with no names, more exactly the files with the name begins with . for example, in Ubuntu OS, if the file names begin with ., it is considered as system files and automatically hidden, you see? what do you think?

edenvidal commented 1 year ago

@sbsoso0411 i love this idea! Let's go with it and see later how it all works. 🙌

edenvidal commented 1 year ago

@sbsoso0411 not yet applied on the files view items: