search

wearpants / twiggy

Pythonic logger, shipped in Redhat & Debian
BSD 3-Clause "New" or "Revised" License
47 stars 11 forks source link

Fix pep8 #67

Closed abadger closed 7 years ago

abadger commented 7 years ago

This PR builds on top of the pyflakes fixes in PR #66 to complete the changes that are needed for flake8 to pass on the tests and twiggy directories.

I've separated the fixes into two commits but you can squash them on merging. The two new commits are:

I separated them for review because fixing the line too long warnings sometimes makes the code uglier in my opinion. I didn't want to predjudice the first class of fixes with the second ;-) If you like both sets of changes feel free to squash. If you don't like the line too long changes we can do something like configure flake8 to give us a longer line length (Raymond Hettinger recommends around 100 characters) or have it disable that check altogether.

wearpants commented 7 years ago

A line length of 100 looks sensible, let's try that?

abadger commented 7 years ago

Okay Updated to use a maximum line length of 100. Looks much better. The only set of lines I was still unhappy with are here: https://github.com/wearpants/twiggy/pull/67/files#diff-184907c983fa1fd4e1a8f0e8c9b11b1dL35 I could live with it but the formatting is a little odd.