search

wearpants / twiggy

Pythonic logger, shipped in Redhat & Debian
BSD 3-Clause "New" or "Revised" License
47 stars 11 forks source link

Unicode error fixes #83

Closed abadger closed 6 years ago

abadger commented 6 years ago

This branch will eventually have unicode error fixes. For starters, I'm updating unittests to get them ready to have non-ascii values which will fail so that we know if the fixes are doing what htey're supposed to.

wearpants commented 6 years ago

Is this ready to merge?

Also, just wanted to make sure we covered both str & bytes for the message text (first arg to debug(..)) - saw that for fields & names, wasn't sure if it was covered elsewhere...

abadger commented 6 years ago

Not ready yet. Test failure I think I need to pin the version of pytest (newer pytest deps aren't python 3.3 or python 2.6 compatible) and this is only fixing one thing. I think most of the issues are in the Messages class but there is likely to be some errors in the Outputs once Messages is fixed and istr lib/converter.py having issues too.

I've been trying to update unittest code to use pytest.mark.parametrize and add in non-ascii values as I go along as well.

abadger commented 6 years ago

Okay, this is now mergable if we want. It isn't a fix for all of our unicode problems but it fixes one case. It also adds the helper utilities (to_text, to_bytes, and to_native) that we'll want as we fix the rest of the code base.