search

wearpants / twiggy

Pythonic logger, shipped in Redhat & Debian
BSD 3-Clause "New" or "Revised" License
47 stars 11 forks source link

Json formatter #87

Open wearpants opened 6 years ago

wearpants commented 6 years ago

initial work on #85

abadger commented 6 years ago

Looks good. The two things I would do are add sets (collections.Set) to the things that JsonEncoder can handle and use positions in format strings so that it works on python2.6.

wearpants commented 6 years ago

I'm struggling with this time thing - the default field on global log is time.gmtime and named time. Kinda wish it was a proper datetime and called timestamp, but afraid to break 3rd party stuff.

On Dec 4, 2017 9:39 AM, "Toshio Kuratomi" notifications@github.com wrote:

Looks good. The two things I would do are add sets (collections.Set) to the things that JsonEncoder can handle and use positions in format strings so that it works on python2.6.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wearpants/twiggy/pull/87#issuecomment-348980752, or mute the thread https://github.com/notifications/unsubscribe-auth/AAe2AATZgu1ItDW90aGWASwdhwCwpav6ks5s9AQogaJpZM4Qz5r7 .