search

wearpants / twiggy

Pythonic logger, shipped in Redhat & Debian
BSD 3-Clause "New" or "Revised" License
47 stars 11 forks source link

Fix circular imports #89

Closed abadger closed 6 years ago

abadger commented 6 years ago

Circular imports were preventing twiggy from working when it was installed in non-development mode.

abadger commented 6 years ago

This should test fine once https://github.com/wearpants/twiggy/pull/90 is merged,

abadger commented 6 years ago

@wearpants Does this look good to you? I'm not sure why running from the checkout works but installing master python3 setup.py install --user ; python3 -c 'import twiggy ; print(twiggy.__file__)' seems to fail without this change so it seems pretty major.

wearpants commented 6 years ago

Should be ok, want to take a 2nd close look this afternoon.

Worth adding a basic test for "it installs & imports correctly"? Not sure what that would look like, it's a bit circular o_O

On Thu, Sep 6, 2018, 12:22 PM Toshio Kuratomi notifications@github.com wrote:

@wearpants https://github.com/wearpants Does this look good to you? I'm not sure why running from the checkout works but installing master python3 setup.py install --user ; python3 -c 'import twiggy ; print(twiggy.file)' seems to fail without this change so it seems pretty major.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/wearpants/twiggy/pull/89#issuecomment-419155959, or mute the thread https://github.com/notifications/unsubscribe-auth/AAe2AMoVaChqHnZtoJnskmgmXQepgcHbks5uYUuwgaJpZM4WcEYp .

wearpants commented 6 years ago

This is much nicer anyway.