search

weather-gov / weather.gov

weather.gov 2.0
Other
325 stars 9 forks source link

Firefox tests are disabled in CI/CD #1440

Open greg-does-weather opened 2 months ago

greg-does-weather commented 2 months ago

Description

In #1433, we disabled Firefox tests in our CI/CD environment because they were intermittently failing in unpredictable ways. Rather than halt all other PRs until we can figure out why that is and mitigate it, we opted to disable Firefox tests entirely for now. However, we want to add them back to increase the likelihood that the site will work for our Firefox users.

Acceptance criteria

colinmurphy01 commented 1 month ago

When do we want to pick this up?

colinmurphy01 commented 2 weeks ago

@greg-does-weather when can we re-enable these?

greg-does-weather commented 2 weeks ago

Whenever we have the time to sit down and figure out why the tests fail intermittently and mitigate it. We haven't done that yet. It might be worth trying to turn them back on because Eric and Logan's work on parallelizing the tests may have done the trick since they also turned on retries. Still, ideally we wouldn't have any flaky tests, so the best case is to figure out why they sometimes fail.

colinmurphy01 commented 2 weeks ago

This is then blocked by #1675