search

weather-gov / weather.gov

weather.gov 2.0
Other
325 stars 8 forks source link

Setup "outside" tests to run on every PR #1551

Open jamestranovich-noaa opened 2 months ago

jamestranovich-noaa commented 2 months ago

Description

Once we have "outside" tests working (https://github.com/weather-gov/weather.gov/issues/1549) and documented how and why to use "outside" vs Drupal tests (https://github.com/weather-gov/weather.gov/issues/1550) then we should set up these tests to run on every PR as part of our usual CI workflow. Part of https://github.com/weather-gov/weather.gov/issues/1352

Questions and Considerations

None.

Acceptance Criteria

jamestranovich-noaa commented 3 weeks ago

This isn't as straightforward as it seemed, because we have a fairly complicated Github Actions setup with Playwright that we will have to re-do and combine when we migrate to Gitlab CI. There's also a larger issue that might need dev discussion: eventually I think e2e testing should be fully on the dedicated test environment. And this kinda ties in with the deprecation of Cypress as well.

I think I'm going to punt this for the time being since we can still run outside tests locally and currently only the API functionality is being tested via outside tests.

This is blocked till we move to Gitlab.

jamestranovich-noaa commented 3 weeks ago

Wrote up larger issue thoughts here: https://github.com/weather-gov/weather.gov/issues/1795 -- I think we should address outside testing as part of that effort. Leaving this ticket open for a bit longer, in case we want discussion around outside testing functionality.