weatherfactory / cultistsimulator-visible

Read-only preview builds of Cultist Simulator for the convenience of modders and the curious.
https://weatherfactory.biz/cultist-simulator/
37 stars 5 forks source link

If game was unpaused, time passes on Save & Quit #193

Closed Chelnoque closed 1 year ago

Chelnoque commented 2 years ago
  1. Game is unpaused.
  2. You press ESC.
  3. Game is paused.
  4. You press Save & Quit.
  5. Time passes (in the real world) while the game saves.
  6. Right before the game leaves the tabletop scene, you can see that in-game timers slightly changed.
alexiskennedy commented 2 years ago

Details of subj unclear :) Is it failing to pause on save, saving in an inconsistent state, or? This could be a pri 7 or a pri 3

Chelnoque commented 2 years ago

Subj clarified! But I did a bit more testing - the save still loads correct, pre-pause timer values. So while it can alarm people, the problem here is only the UI one.

alexiskennedy commented 2 years ago

I'm surprised how relieved I am by that. Thanks.

If the UI bug has been there for the last few versions, I would even make this pri 9.

Chelnoque commented 2 years ago

(I'm fairly sure it's here since the rewrite)

alexiskennedy commented 1 year ago

No more reports, it's clearly not worrying people