search

weatherfactory / cultistsimulator-visible

Read-only preview builds of Cultist Simulator for the convenience of modders and the curious.
https://weatherfactory.biz/cultist-simulator/
36 stars 6 forks source link

Description window goes astray #237

Closed alexiskennedy closed 1 year ago

alexiskennedy commented 1 year ago

Intermittent weird window issue?

@Chelnoque you may remember responding to this lady (see 1.jpg). I asked her to disable mods, cos there were loads, and she says "Hello. I disabled all mods, deleted the "save.json" file, purged the in-game save, but the problem is still there. However, this has become less frequent."

window_issues.zip

Only report I've seen.

Chelnoque commented 1 year ago

A "video" is mentioned in Steam discussion. Was it send after all, and if yes, can I see it? I'm still not 100% sure I understand what the problem is.

alexiskennedy commented 1 year ago

aha, yes! (it was an embedded link so it didn't end up in the zip file)

https://drive.google.com/file/d/1Mq4ubq5PO9t369oXpw3rfoBcimIQ0EP2/view

Chelnoque commented 1 year ago

The bug looks hella like an exception in situation window display, and the game appears to be heavily modded, including DLLs, so my initial bet is on that. Will try to recreate.

alexiskennedy commented 1 year ago

They did say they've disabled all mods and purged the save... but 'less frequent' may mean 'different problem with a similar symptom that doesn't appear in the video'

Chelnoque commented 1 year ago

Another thing that catches the eye is that the game on video runs in pretty low FPS (unless that's a video thing). Tried that avenue, no luck for now. Added some precautions in that regard anyway, but I don't think this is it. Will look further.

Chelnoque commented 1 year ago

Recent developments: a) Precautions didn't work b) But got another report with a confirmation that it's a FPS issue after all

Chelnoque commented 1 year ago

What an absolute specimen. a) behaviour is different between the build and the editor b) sends an exception that isn't logged in the console/player.log

Apparently, when the lag hits the hardest, Unity's deltaTime can become an infinity (doesn't entirely correct, but mkay). This forces window positioner to do some nonsense math that makes its brains 🥴. Fixed the thing.

Avoiding other silent errors will require some consideration.

Fixed in ORACHE.

alexiskennedy commented 1 year ago

Thanks chap.

"other silent errors " ...which are related to low FPS?

Chelnoque commented 1 year ago

Other theoretical possible future silent errors which may be or may not be related to low FPS.