search

weatherstorm / Sofaskin-CW9009

Sofaskin-CW9009 skin for Weewx is a modified version of the Sofaskin developed by Sven at https://neoground.com/portfolio/neowx/. He no longer supports the original skin. Please see the readme for dependency requirements to use this skin.
http://www.centuryfarmweather.com
MIT License
17 stars 11 forks source link

Use `preg_split` instead of `split` in text.php.tmpl #5

Closed KurtJacobson closed 6 years ago

KurtJacobson commented 6 years ago

text.php.tmpl uses the PHP function split which was deprecated in PHP 5.3.0, and completely removed in PHP 7.0.0. This causes servers running PHP 7.0.0 or later to completely fail to load the Monthly Reports page. Since the current stable is 7.2.1, and most up-to-date servers will probably be running at least 7.0.14, users are likely to encounter this problem. split should be replaced with preg_split.

weatherstorm commented 6 years ago

Thank you. In order for the preg_split to work correctly the pattern has to be updated to "/[\s-.]/"

KurtJacobson commented 6 years ago

Great thank you! I did not notice that the regex syntax had changed with the new extension.