Support Wildcards - Githubissues

weave-lab / cached-certificate-operator

A Kubernetes operator that allows for automatic provisioning and distribution of cert-manager certs across namespaces

Apache License 2.0

12 stars 2 forks source link

Support Wildcards #4

Closed agates4 closed 6 months ago

agates4 commented 2 years ago

This solves #3

Changes

Replacing occurances of "*" in the secret name to instead be "x"
An issue occured where the hashing would produce backslash characters - now replacing occurances of backslash characters with an "x"

Benefits

Cached certificates such as:

---
apiVersion: cert-manager.io/v1
kind: ClusterIssuer
metadata:
name: selfsigned-issuer
spec:
selfSigned: {}
---
apiVersion: cache.weavelab.xyz/v1alpha1
kind: CachedCertificate
metadata:
name: wildcard-cert
spec:
issuerRef:
  name: selfsigned-issuer
  kind: ClusterIssuer
dnsNames:
  - "*.example.com"

Work without problems! 🎉

carsonoid commented 6 months ago

Thanks for the submission! I'm sorry this change fell though for me. I get a lot of github emails so most of them get lost. My only issue with this solution is that it can enable conflicts for cases where both a wildcard and an x host exist. Ex:

x.site.com and *.site.com` will end up with the same upstream cert name and have unexpected behavior. PR #6 uses hashes to ensure that conflicts like this are not possible in newer versions.

agates4 commented 6 months ago

Thanks for the submission! I'm sorry this change fell though for me. I get a lot of github emails so most of them get lost. My only issue with this solution is that it can enable conflicts for cases where both a wildcard and an x host exist. Ex:

x.site.com and *.site.com` will end up with the same upstream cert name and have unexpected behavior. PR #6 uses hashes to ensure that conflicts like this are not possible in newer versions.

Solid, thanks for the changes!