weavejester / clucy

Clojure interface to Lucene
Eclipse Public License 1.0
172 stars 58 forks source link

Update to Lucene 3.5.0 #8

Closed wwentland closed 12 years ago

wwentland commented 12 years ago

Hi,

the three commits essentially upgrades clucy to use Lucene 3.5.0. The most intrusive change is that the index is no longer a struct, but the actual index object. This is due to a change in Lucene 3.5.0 in that index optimization calls are discouraged. See LUCENE-3454 for a discussion of this change, which has been summarised in the release notes as:

"Renamed IndexWriter.optimize to forceMerge to discourage use of this method since it is horribly costly and rarely justified anymore."

The index can still be manually "optimized" by calling forceMerge directly, which should probably be documented in the README. It might even make sense to introduce a wrapper function force-merge [index max-segments] around IndexWriter.forceMerge, but I haven't done that yet.

Thank you and may you have a nice day!

weavejester commented 12 years ago

Sorry for taking so long to look at this. I've been a little busy with Ring and Hiccup lately, so I've had no time to look into this change. I should have some time to review this request and update Clucy in the next week or so.