search

weavejester / compojure-example

An example Compojure project
57 stars 29 forks source link

uberwar does not work under compojure 1.1.2 #5

Closed ghost closed 12 years ago

ghost commented 12 years ago

Upgrade to version 1.1.2 of compojure, was running "lein ring uberwar", there is no reaction In 1.1.1 there was no problem.

The compilation, but to sleep in the code below.

https://github.com/ring-clojure/ring/blob/1.1.4/ring-core/src/ring/middleware/multipart_params/temp_file.clj#L8

Could you confirm? Thank you.

weavejester commented 12 years ago

Confirmed. At least, there's something odd going on with Lein 1.7.1 and Lein-Ring. Lein 2.0.0-preview10 seems to have no issues. Lein 1.7.1 will work with ring/ring-core 1.1.2 but not 1.1.3 for some reason. Very little changed between those two versions, so I don't know why one would work and one wouldn't. I'll investigate further.

weavejester commented 12 years ago

The cause is that ring.middleware.multipart-params/wrap-multipart-params creates a thread when it's called in Ring 1.1.2 and above. This causes the compilation to never return in Lein 1.7.1, because it's waiting for the thread to finish. I'll fix this in Ring and release a new version.

ghost commented 12 years ago

Thank you for confirmation. I wait for the next release.

weavejester commented 12 years ago

Fixed in Compojure 1.1.3 (and Ring 1.1.5)