weavejester / eftest

Fast and pretty Clojure test runner
425 stars 40 forks source link

Run namespaces in their own thread pool #72

Closed eraserhd closed 5 years ago

eraserhd commented 5 years ago

Closes #71

Except for setting up and tearing down "once fixtures", namespace threads are parked, meaning these cores aren't available for running tests. Additionally, when there are less threads than namespaces, the runner would deadlock when all test executor threads were being used by namespaces waiting for tests.

eraserhd commented 5 years ago

@weavejester I extracted a protocol to remove several conditionals instead of using delay. If that doesn't look better to you, I'll redo it.

Not entirely comfortable with the protocol name.

And, let me know if I should squash the commits.

Thanks! -Jason

eraserhd commented 5 years ago

That's all feedback addressed @weavejester

weavejester commented 5 years ago

Thanks for the update. Can you reformat the commit message to:

Run namespaces in their own thread pool

Except for setting up and tearing down "once fixtures", namespace
threads are parked, meaning these cores aren't available for running
tests. Additionally, when there are less threads than namespaces, the
runner would deadlock when all test executor threads were being used by
namespaces waiting for tests.

Closes #71.

So a wordwrap at the more standard 72 characters rather than 80 for the commit body.

Then I should be able to merge.

eraserhd commented 5 years ago

@weavejester done

weavejester commented 5 years ago

Manually merged.