weavejester / environ

Library for managing environment variables in Clojure
924 stars 71 forks source link

Boot Environ doesn't work in boot-test #56

Closed adstage-david closed 8 years ago

adstage-david commented 8 years ago

Been trying to track down why environ isn't working in our test environment. Initially I looked at issue #46, but as it was solved I spent some time looking elsewhere. When I finally started drilling down, it became clear that only the values from the environ boot task were missing and only in the test environment, which indicates #46 might not have been fully solved.

Specifically, it looks like some of the refactoring that happened in #47 might have broken the functionality:

https://github.com/weavejester/environ/pull/47#discussion_r50415816

(doto fileset ....) returns fileset, but we need it to return a mutated version of the fileset with the new .boot-env file added and committed. I inlined my own version of the environ boot task with this change and my environ properties are making it through in a .boot-env file to the test directory.