Closed lucywang000 closed 4 years ago
Thanks for the PR. zprint in both cases might be a good idea, as I've had issues with puget, but that should be a separate PR.
I have some standard contributing guidelines that I forgot to add to this repository. Can you squash your commits down and ensure the commit message is formatted according to the guideline?
@weavejester PTAL.
drop puget, use zprint in both clj and cljs
That's good work, but as I said in my previous comment, that should be a separate PR. Can you revert that change for this PR, as it's beyond the scope of this feature.
@weavejester Reverted the "drop puget" part as you suggested.
@weavejester could you please take a look again? I have been using this ever since and it works pretty well for me.
Sorry, I've been a little busy with Ring. If the indentation is fixed it should be good to merge.
Thanks! Can you change the commit message to Add support for ClojureScript
? Then I'll merge it in.
Some notable changes:
print-opts
in a cljs file.case
macro ofnet.cgrand/macrovich
is used in thep*
function to make it generate clj/cljs code properly. Reader conditionals can't work here - this function is always compiled as clj code when being used as a data reader, so the cljs branch would never be used in this case. Themacrovich/case
macro could help this because it's a macro so it could generate different code for clj/cljs during macro expansion.