Open joshavg opened 5 years ago
Thanks for the PR. Can you ensure the commit follows these contributing guidelines, and can you also remove the docstring from the private function?
I also think that this might be more flexible if we check for ifn?
instead, so if we want to have multiple options set we can supply a set or a function.
Hi, I hope, I followed the guidelines better this time. Simply switching sequential
for ifn?
didn't work out that well. Maybe you can come up with a more elegant solution?
Looking for this feature as well. What needs to happen for this to move forward?
Looking for this feature as well. What needs to happen for this to move forward?
The code needs to be updated as per my previous comment. That's why this issue is marked as "waiting on dev".
Thanks for the quick reply. Sorry I didn't mean to sound pushy. I understand that's ideally what needs to happen (I did see the tag), but since it's been more than 5 years since you requested the change and more than 2 years from the addition of the tag and the dev hasn't responded, I am wondering what happens to the PR if the dev never responds. Does it stay in limbo forever? I imagine it'd be awkward if someone else agreed with your changes and issued the same PR with those changes. I'm new to Clojure so I'm genuinely curious.
Someone else can make the same change and submit a PR. In which case I'll merge that PR and close this one.
This way, multi selectes can be realized where the select tag hast the attribute multiple="multiple" together with size="x" and users can ctrl-click multiple options