search

weavejester / hiccup

Fast library for rendering HTML in Clojure
http://weavejester.github.io/hiccup
Eclipse Public License 1.0
2.66k stars 174 forks source link

Clojerl support #185

Open metehan opened 3 years ago

atomist[bot] commented 3 years ago

Commit messages of this repository should follow the seven rules of a great Git commit message, as mentioned in the project's contributing guidelines. It looks like there's a few issues with the commit messages in this pull request:

weavejester commented 3 years ago

Many of the conditional expressions have repetition that could be removed. The tests will also need to be fixed, and the CI needs to include tests for Clojerl as well.

metehan commented 3 years ago

Ops everything failed. @weavejester could you make an initial check if it's generally ok I can make a cleaner PR. @jfacorro have changed file names to follow https://github.com/clojure/clojurescript/wiki/Using-cljc convention. I guess you wouldn't want some filename changes right?

weavejester commented 3 years ago

Using cljc files is fine. The code looks generally okay.