search

weavejester / hiccup

Fast library for rendering HTML in Clojure
http://weavejester.github.io/hiccup
Eclipse Public License 1.0
2.68k stars 175 forks source link

void-tags might not be complete #203

Closed elken closed 1 year ago

elken commented 1 year ago

Probably more suited to a discussion, but per a conversation elsewhere about a similar library; void-tags seems to be missing various svg elements that should be self-closing.

Is this intended, and if not would a small PR be accepted?

Feel free to shoot the messenger if needed! :smile:

weavejester commented 1 year ago

Yep, that's fine, as long as there's a link to something that justifies it.

elken commented 1 year ago

Yep, that's fine, as long as there's a link to something that justifies it.

Cool, they're all on MDN; not included in https://developer.mozilla.org/en-US/docs/Glossary/Void_element because that's for HTML not for SVG. eg animate, path etc

elken commented 1 year ago

Seems I should have checked the spec first, seems like they're in fact not void elements just self-closing ones so I think this change would be a mistake after all.

Apologies for the noise; have a nice day :smile: