search

weavejester / hiccup

Fast library for rendering HTML in Clojure
http://weavejester.github.io/hiccup
Eclipse Public License 1.0
2.68k stars 175 forks source link

Forms and jquery helpers #29

Closed markmfredrickson closed 12 years ago

markmfredrickson commented 13 years ago

I've started building some higher abstractions on top of the forms (labeled items, groups of radio buttons). I also started a set of functions to aid working with the jQuery JavaScript library (loading the files from the Google content delivery network, adding behaviors). This branch merges the two and starts adding jQuery behaviors to form elements.

This branch also includes a small demo to show off various features, a form of documentation by example.

The jQuery related code does not introduce a dependency into hiccup. If people want to use jQuery, it just makes life easier.

weavejester commented 13 years ago

Hi there, sorry for the long delay in responding to this. The last few weeks have been very busy for me.

This code looks really useful, but I think it should be in a separate library to Hiccup. My preference is for small libraries that handle specific tasks, rather than larger libraries that attempt to be "batteries included". With Leiningen and Cake, there isn't really any overhead in adding another dependency.

markmfredrickson commented 13 years ago

Don't worry about response time. Thanks for giving me your thoughts. I'll spin off a separate library.

Is there any of this that should be included in hiccup? Specifically I'm thinking of the additions to form-helpers.clj, which are pretty straight forward:

https://github.com/weavejester/hiccup/pull/29/files#L4R1

markmfredrickson commented 12 years ago

I should note that I've created a separate package to hold all these changes: Burp.