search

weavejester / hiccup

Fast library for rendering HTML in Clojure
http://weavejester.github.io/hiccup
Eclipse Public License 1.0
2.68k stars 174 forks source link

Support for optgroups #68

Closed asmala closed 11 years ago

asmala commented 11 years ago

I added support for optgroups in dropdown menus. The syntax is:

(select-options [["Optgroup label"
                  ["Nested option #1"
                   "Nested option #2"
                   ["Nested option #3" "nested-value-3"]]]])

This should not break backwards compatibility, as the whole test suite passes. On that note, I also added tests to cover this new functionality.

dubiousdavid commented 11 years ago

Any reason this hasn't been merged in? This would be really nice to have.

asmala commented 11 years ago

I've been wondering about the same. Chances are James (weavejester) has been quite busy recently since the last commits to Hiccup are from early October. Hope he'll get around to taking a look soon though.

weavejester commented 11 years ago

Yes, sorry for the delay in response. I've had a lot of pull requests and not a huge amount of time, I'm afraid. From a cursory look this looks fine, but it'll be a few days before I can merge it in.

dubiousdavid commented 11 years ago

Thanks for the update James.

On Nov 13, 2012, at 8:45 AM, James Reeves notifications@github.com wrote:

Yes, sorry for the delay in response. I've had a lot of pull requests and not a huge amount of time, I'm afraid. From a cursory look this looks fine, but it'll be a few days before I can merge it in.

— Reply to this email directly or view it on GitHub.