search

weavejester / lein-ring

Ring plugin for Leiningen
Eclipse Public License 1.0
501 stars 100 forks source link

Do not add a Main-Class attribute by default to a WAR #156

Closed mattunderscorechampion closed 9 years ago

mattunderscorechampion commented 9 years ago

The Main-Class attribute of "clojure.main" was being the war and uberwar when :main was not specified in the project.clj. I have changed this so instead of defaulting to "clojure.main" the Main-Class attribute is excluded.

The default value caused a problem for me when attempting to deploy to Cloudfoundry which detected the .war file as an executable .jar and did not deploy it to a servlet container. https://github.com/cloudfoundry/java-buildpack/blob/master/docs/container-tomcat.md

MichaelBlume commented 9 years ago

Yep, makes sense to me

MichaelBlume commented 9 years ago

Thanks =)

weavejester commented 9 years ago

For future reference, try to make sure that the commit message summary is kept within an appropriate length, i.e. under 70 character.

MichaelBlume commented 9 years ago

Agreed http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html

On Fri, Mar 13, 2015 at 4:19 PM James Reeves notifications@github.com wrote:

For future reference, try to make sure that the commit message summary is kept within an appropriate length, i.e. under 70 character.

— Reply to this email directly or view it on GitHub https://github.com/weavejester/lein-ring/pull/156#issuecomment-79521577.