weavejester / lein-ring

Ring plugin for Leiningen
Eclipse Public License 1.0
501 stars 100 forks source link

Turning off :auto-refresh? for generated artifacts. #184

Closed danielbraun closed 7 years ago

danielbraun commented 7 years ago

Following the same logic as :stacktraces? and :auto-reload?, I believe :auto-refresh? should also be turned off (ignored) for generated artifacts. I was running an uberjar and saw the refresh middleware was still being used.

MichaelBlume commented 7 years ago

Yep, looks right to me, thanks!

Nit-pick (don't worry about fixing, I'll amend): This project adheres to http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html -- in particular, the first line of a commit message should be capitalized, but not end in a period.

MichaelBlume commented 7 years ago

Merged, thanks again =)