weavejester / medley

A lightweight library of useful Clojure functions
Eclipse Public License 1.0
870 stars 67 forks source link

added transducer info to find-first and replace-nth docs #45

Closed ertugrulcetin closed 4 years ago

ertugrulcetin commented 4 years ago

It's more clear when docs says those fns can be used as transducers.

weavejester commented 4 years ago

Thanks. Please make sure your changes and the commit message adhere to the contributing guidelines.

ertugrulcetin commented 4 years ago

@weavejester changed the commit message 🙂

weavejester commented 4 years ago

Thanks, but the commit message is still past tense, not imperative mood, and over 50 characters. Instead, something like this:

Update find-first and replace-nth docstrings

With regard to the code, please ensure the docstrings wrap at 80 characters.

ertugrulcetin commented 4 years ago

@weavejester updated message with that one :) I'll try to follow this pattern, thanks.

weavejester commented 4 years ago

I notice you have three identically named commits. Can you squash them down?