search

weavejester / meta-merge

A standalone implementation of Leiningen's meta-merge function
104 stars 5 forks source link

Enable clojurescript support #3

Closed SevereOverfl0w closed 8 years ago

SevereOverfl0w commented 8 years ago

This enables clojurescript support. Tests all run (for me). I borrowed a metadatable? function from a util library I found which had clojurescript support.

Would it be worth considering removing direct dependencies on clojure & clojurescript? Then just requiring them in a :dev profile? This is something bidi has done so that you don't pull in unwanted dependencies that way, something to consider perhaps?

weavejester commented 8 years ago

I believe we also need to remove the Java 1.6 branch from the travis configuration for the CI to work with Clojure and ClojureScript 1.7.0.

weavejester commented 8 years ago

Also can you format the subject line of your commit message so that it's under 70 characters and has no ending "."? So something like:

Add ClojureScript support with reader conditionals
weavejester commented 8 years ago

Thanks for your patch. I've made a few notes and comments of things that need to be changed.