Closed venantius closed 8 years ago
Currently seems to be failing the tests...
Let me tuck into this a bit. I didn't actually run the tests locally before pushing this up 😜
Tests now pass. Two concerns are outstanding:
Thanks! Could you change the commit message to something a little more in line with the repo? So perhaps:
Check migrations table exists before creation
Rather than attempting to create the migration table and ignoring the
exception, instead use the .getTables method to check the migration
table exists first.
Updated!
Thanks! If you get rid of that additional space it should be good to merge.
I should probably add cljfmt to my CI scripts...
Fixed!
Perfect, thanks!
@weavejester Do you have any ETA of a 0.6.1
release , with this in? This actually solves an issue I'm having with transactions around ragtime migrations: ignoring a failed CREATE TABLE ragtime_migrations ...
(which the current source does) can bring the connection in a bad state, breaking the surrounding transaction.
Done. Sorry for the delay.
No problem at all, thank you for the quick release!
This commit uses the
java.sql
getMetaData and getTables methods to check for the migration table's existence rather than trying to create it and just handling the exception.This approach is preferable to the previous approach in that it does not invalidate an ongoing transaction that might contain Ragtime migrations.