search

weavejester / ragtime

Database-independent migration library
Eclipse Public License 1.0
610 stars 85 forks source link

Fix database connection leak #106

Closed metametadata closed 8 years ago

metametadata commented 8 years ago

In a worst case it can lead to the exhaustion of a connection pool and this is actually what I experience on running unit tests where I clear and migrate a test db before each test.

metametadata commented 8 years ago

Ah, looks like I've broken library tests.

weavejester commented 8 years ago

Thanks for the patch! I have a few suggestions I'll add as inline comments

metametadata commented 8 years ago

Done!

weavejester commented 8 years ago

Perfect, thanks!