weavejester / ragtime

Database-independent migration library
Eclipse Public License 1.0
610 stars 85 forks source link

Allow a single space for the SQL separator marker '--;;' #160

Closed dharrigan closed 10 months ago

dharrigan commented 10 months ago

This commit loosens the restriction on the SQL separator marker from being '--;;' to also allow '-- ;;'. In doing so, it aids those developers who are using ragtime for MySQL migrations as MySQL requires that comments starting with '--' are immediately followed by a space (or control character) before any other character.

fixes #159

-=david=-

weavejester commented 10 months ago

Thanks for the PR! Can you change the commit message to:

Fix SQL separator marker for MySQL

Allow '-- ;;' as a separator marker in order to support MySQL, which
does not allow '--;;' as a valid comment.

Fixes #159.

This ensures the commit message aligns with the contributor guidelines.

dharrigan commented 10 months ago

Hi,

No problem. Done.

-=david=-

weavejester commented 10 months ago

Thanks! Can you also remove the -=david=- signature at the bottom? I'm guessing it's something you have that's automatically added to your commits?

dharrigan commented 10 months ago

Hi,

Removed that too. It's my tagline - my signature. Hope all is ship-shape now :-)

-=david=-

weavejester commented 10 months ago

Perfect, thank you!