search

weavejester / ring-serve

Ring development web server
Eclipse Public License 1.0
25 stars 6 forks source link

ring-serve project.clj pulls in ring 1.0.0 (needs to be updated to 1.1.0) #4

Open jlr opened 12 years ago

jlr commented 12 years ago

Hi, thanks for your great work on compojure and your other projects.

I'm just asking if you could please update the 'project.clj' of ring-serve to use [ring "1.1.0"].

Ring-serve pulls in ring 1.0.0 which creates a problem in my project because recent versions of hiccup changed a namespace name that ring 1.0.0 looks for. Ring 1.1.0 works fine with the newer hiccup.

Thanks! p.s. I just stumbled on 'ring-server', should I be using that instead of 'ring-serve'?

(more details, in case you want them: in ring 1.0.0, ring.middleware.stacktrace included hiccup.page-helpers, and hiccup now changed that ns to 'hiccup.page'. Ring 1.1.0 already updated to the new name. So since my project uses the latest version of hiccup, when I try to use ring.serve, it pulls: ring-serve -> ring 1.0.0 -> ring.middleware.stacktrace with the old ns name, and fails saying it can't find 'hiccup.page-helpers'.)

weavejester commented 12 years ago

Ring-serve pulls in ring 1.0.0 which creates a problem in my project because recent versions of hiccup changed a namespace name that ring 1.0.0 looks for. Ring 1.1.0 works fine with the newer hiccup.

Just explicitly include Ring 1.1.0 in your project dependencies. Leiningen will ensure you're using the latest versions.

p.s. I just stumbled on 'ring-server', should I be using that instead of 'ring-serve'?

Eventually I'll move everything from "ring-serve" to ring-server and deprecate the former in favour of the latter, but not all functionality has been moved over yet (such as the swank middleware).