search

weavejester / ring-server

51 stars 24 forks source link

SSL Environment Variables #5

Open JulianBirch opened 11 years ago

JulianBirch commented 11 years ago

Sorry, but I don't know quite where to put this one. lein-ring documents that it supports the PORT and SSLPORT environment variables, but as far as I can tell, it doesn't. This could be addressed at the lein-ring, ring-server or ring-jetty-adapter level. I think ring-server is the right place.

If you agree, I'd be happy to stick together a pull request fixing this.

(Whilst we're on the subject, I'm not convinced PORT is a good name for an environment variable.)

weavejester commented 11 years ago

It looks like SSLPORT hasn't been implemented, but PORT should work fine.

Regarding PORT as an environment variable, that's what's used by many cloud-based hosting services like Heroku, which is why it was chosen.

JulianBirch commented 11 years ago

Sorry, yes, I agree PORT works. And that consistency is a good thing.

simon-brooke commented 7 years ago

Browsing the code, I cannot see that SSL is supported at all. Am I missing something?

weavejester commented 7 years ago

@simon-brooke The options to standalone/serve are just passed straight through to the Jetty adapter, which does support SSL. However, it's more common to implement SSL via a proxy or load balancer, rather than on the adapter itself.

JulianBirch commented 6 years ago

Indeed. My original use case was to test https redirection code locally.