search

weavejester / ring-webjars

Ring middleware to serve assets from WebJars
36 stars 4 forks source link

updated dependencies, removed slf4j #3

Closed yogthos closed 9 years ago

yogthos commented 9 years ago

slf4j doesn't appear to be necessary and can conflict with other dependencies such as Immutant

weavejester commented 9 years ago

Pull requests should contain commits relating to a single change. When unrelated changes are grouped together, it makes it harder to merge pull requests.

The commit message should match the style used in the repository, so imperative tense with a capitalised first letter. For example:

Update dependencies

The version of Clojure is kept deliberately at the minimum supported version to ensure backward compatibility. I don't see any reason to remove compatibility for Clojure 1.5.1 at this point.

yogthos commented 9 years ago

Since it's such a small change, could I just close the pr and you just release it? Technically the test doesn't really need to be updated either, since the version of bootstrap doesn't really affect it.

weavejester commented 9 years ago

Sure. Done.

yogthos commented 9 years ago

Great, thanks!